[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=352190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352190
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/19 20:38
Start Date: 02/Dec/19 20:38
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #10236: [BEAM-8335]
Add method to PipelineInstrument to create background caching pipline
URL: https://github.com/apache/beam/pull/10236#discussion_r352812007
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -205,7 +351,7 @@ def _process(self, pcoll):
v = PreprocessVisitor(self)
self._pipeline.visit(v)
- def _write_cache(self, pcoll):
+ def _write_cache(self, pipeline, pcoll):
Review comment:
Could we omit this from the signature since all mutation happens to the same
runner pipeline instance instantiated by this instrument instance? It should be
self contained.
If you want to unit test in a non-self-contained way, we can extract the
logic into a static function for re-use. See the comment in the unit test below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 352190)
Time Spent: 38h 10m (was: 38h)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 38h 10m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
