[ 
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=352414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352414
 ]

ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Dec/19 03:01
            Start Date: 03/Dec/19 03:01
    Worklog Time Spent: 10m 
      Work Description: bumblebee-coming commented on issue #10159: [BEAM-8575] 
Added a unit test to CombineTest class to test that Combi…
URL: https://github.com/apache/beam/pull/10159#issuecomment-560976883
 
 
   I re-implemented the test using TestStream, and fixed the order of 
add_elements and advance_watermark_to.
   However, elements are still not discarded in DISCARDING mode.
   
   I also tried mixing and matching FixedWindows, GlobalWindows with 
trigger=Repeatedly(AfterCount(1)), trigger=AfterWatermark(early=AfterCount(1)).
   all cases:                                                                   
                                                       RESULT
   FixedWindows      trigger=Repeatedly(AfterCount(1))        ACCUMULATING      
                   [15]       
                                                                                
               DISCARDING                               [15]
   FixedWindows      trigger=AfterWatermark(early=AfterCount(1))  ACCUMULATING  
       [15, 15]
                                                                                
                          DISCARDING                 [15, 0]
   GlobalWindows    trigger=Repeatedly(AfterCount(1))                   
ACCUMULATING                [15]
                                                                                
                          DISCARDING                     [15]
   GlobalWindows    trigger=AfterWatermark(early=AfterCount(1))   ACCUMULATING  
       [15, 15]
                                                                                
                          DISCARDING                 [15, 0]
   
   It seems in both ACCUMULATING mode and DISCARDING mode, all the 
TimestampedValues are in one single pane.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 352414)
    Time Spent: 21h 40m  (was: 21.5h)

> Add more Python validates runner tests
> --------------------------------------
>
>                 Key: BEAM-8575
>                 URL: https://issues.apache.org/jira/browse/BEAM-8575
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-py-core, testing
>            Reporter: wendy liu
>            Assignee: wendy liu
>            Priority: Major
>          Time Spent: 21h 40m
>  Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to 
> improve test coverage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to