[
https://issues.apache.org/jira/browse/BEAM-1440?focusedWorklogId=352643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352643
]
ASF GitHub Bot logged work on BEAM-1440:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/19 14:15
Start Date: 03/Dec/19 14:15
Worklog Time Spent: 10m
Work Description: kamilwu commented on pull request #9772: [BEAM-1440]
Create a BigQuery source that implements iobase.BoundedSource for Python
URL: https://github.com/apache/beam/pull/9772#discussion_r353202013
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -700,30 +675,19 @@ def _export_files(self, bq):
bigquery.TableSchema instance, a list of FileMetadata instances
"""
job_id = uuid.uuid4().hex
- destination = self._get_destination_uri(self.gcs_bucket_name, job_id)
- job_ref = bq.perform_extract_job([destination], job_id,
+ job_ref = bq.perform_extract_job([self.gcs_location], job_id,
self.table_reference,
bigquery_tools.ExportFileFormat.JSON,
include_header=False)
bq.wait_for_bq_job(job_ref)
- metadata_list = FileSystems.match([destination])[0].metadata_list
+ metadata_list = FileSystems.match([self.gcs_location])[0].metadata_list
Review comment:
Yes. The thing I used is called `Single wildcard URI`[1]. In this case, an
extract job creates one or many files and all of them are created in the same
directory.
[1]
https://cloud.google.com/bigquery/docs/exporting-data#exporting_data_into_one_or_more_files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 352643)
Time Spent: 12h (was: 11h 50m)
> Create a BigQuery source (that implements iobase.BoundedSource) for Python SDK
> ------------------------------------------------------------------------------
>
> Key: BEAM-1440
> URL: https://issues.apache.org/jira/browse/BEAM-1440
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 12h
> Remaining Estimate: 0h
>
> Currently we have a BigQuery native source for Python SDK [1].
> This can only be used by Dataflow runner.
> We should implement a Beam BigQuery source that implements
> iobase.BoundedSource [2] interface so that other runners that try to use
> Python SDK can read from BigQuery as well. Java SDK already has a Beam
> BigQuery source [3].
> [1]
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery.py
> [2]
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/iobase.py#L70
> [3]
> https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java#L1189
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
