[
https://issues.apache.org/jira/browse/BEAM-4287?focusedWorklogId=352923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352923
]
ASF GitHub Bot logged work on BEAM-4287:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/19 19:35
Start Date: 03/Dec/19 19:35
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #10258: [BEAM-4287] Add
trySplit API to Java restriction tracker matching Python SDK definition. Remove
GetPartition()
URL: https://github.com/apache/beam/pull/10258#issuecomment-561322628
> Looks pretty good, just need to get it passing the Precommit. Looks like
you're missing some changes in RestrictionTrackersTest:
>
> ```
> 10:25:53
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/sdks/java/fn-execution/src/test/java/org/apache/beam/sdk/fn/splittabledofn/RestrictionTrackersTest.java:40:
error: <anonymous
org.apache.beam.sdk.fn.splittabledofn.RestrictionTrackersTest$1> is not
abstract and does not override abstract method trySplit(double) in
RestrictionTracker
> 10:25:53 new RestrictionTracker() {
> 10:25:53 ^
> 10:25:53
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/sdks/java/fn-execution/src/test/java/org/apache/beam/sdk/fn/splittabledofn/RestrictionTrackersTest.java:52:
error: method does not override or implement a method from a supertype
> 10:25:53 @Override
> 10:25:53 ^
> 10:25:53
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/sdks/java/fn-execution/src/test/java/org/apache/beam/sdk/fn/splittabledofn/RestrictionTrackersTest.java:87:
error: RestrictionTrackerWithSize is not abstract and does not override
abstract method trySplit(double) in RestrictionTracker
> 10:25:53 private static class RestrictionTrackerWithSize extends
RestrictionTracker<Object, Object>
> 10:25:53 ^
> 10:25:53
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/sdks/java/fn-execution/src/test/java/org/apache/beam/sdk/fn/splittabledofn/RestrictionTrackersTest.java:105:
error: method does not override or implement a method from a supertype
> 10:25:53 @Override
> 10:25:53 ^
> ```
>
> Out of curiosity, what is the Partition stuff and why is it being removed?
Just an outdated part of the SDF spec?
It was related to how we report progress/backlog (specifically in streaming)
but we can now report it via the sized elements that are being returned as part
of the split.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 352923)
Time Spent: 40m (was: 0.5h)
> SplittableDoFn: splitAtFraction() API for Java
> ----------------------------------------------
>
> Key: BEAM-4287
> URL: https://issues.apache.org/jira/browse/BEAM-4287
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> SDF currently only has a checkpoint() API. This Jira is about adding the
> splitAtFraction() API and its support in runners that support the respective
> feature for sources.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
