[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=352978&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352978
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/19 21:12
Start Date: 03/Dec/19 21:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9720: [BEAM-8335]
Add initial modules for interactive streaming support
URL: https://github.com/apache/beam/pull/9720#discussion_r353423627
##########
File path: model/interactive/src/main/proto/beam_interactive_api.proto
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * Protocol Buffers describing a service that can be used in conjunction with
+ * the TestStream class in order to control a pipeline remotely.
+ */
+
+syntax = "proto3";
+
+package org.apache.beam.model.interactive.v1;
+
+option go_package = "interactive_v1";
+option java_package = "org.apache.beam.model.interactive.v1";
+option java_outer_classname = "BeamInteractiveApi";
+
+import "beam_runner_api.proto";
+import "google/protobuf/timestamp.proto";
+
+
+service InteractiveService {
Review comment:
I would have suggested to make a new transform definition called
ExternalTestStream (or some similar name) which is independent of this
TestStream.
In general I believe it would be best if transforms had a narrow scope as
the cost of choosing a new URN and to have a specific payload is meant to be
inexpensive. The payload can be arbitrarily chosen and does not necessarily
need to be in proto.
Now for a runner to support TestStream it now has to say what parts of the
TestStream specification it supports which is a hassle to deal with. Also this
leads to others following the same pattern since adding a new field to an
existing transform may be backwards compatible from a decoding perspective but
isn't backwards compatible if it changes the intent of the transform since a
runner may not know of that field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 352978)
Time Spent: 40h 20m (was: 40h 10m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 40h 20m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)