[
https://issues.apache.org/jira/browse/BEAM-8869?focusedWorklogId=353257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353257
]
ASF GitHub Bot logged work on BEAM-8869:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/19 07:26
Start Date: 04/Dec/19 07:26
Worklog Time Spent: 10m
Work Description: mwalenia commented on pull request #10266: [BEAM-8869]
Exclude system metrics test from legacy runner test suite
URL: https://github.com/apache/beam/pull/10266#discussion_r353582467
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MetricsPusherTest.java
##########
@@ -73,7 +74,12 @@ public void pushesUserMetrics() throws Exception {
assertThat(TestMetricsSink.getCounterValue(COUNTER_NAME),
is(NUM_ELEMENTS));
}
- @Category({ValidatesRunner.class, UsesAttemptedMetrics.class,
UsesCounterMetrics.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesAttemptedMetrics.class,
+ UsesCounterMetrics.class,
+ UsesSystemMetrics.class
Review comment:
I don't think so - MetricsPusher is used in both portable and legacy modes
of runners.
(eg. in
[FlinkRunner](https://github.com/apache/beam/blob/c2f0d282337f3ae0196a7717712396a5a41fdde1/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java#L137)
)
The issue here is that legacy Flink runner doesn't expose system metrics, so
the test involving them made the whole suite fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 353257)
Time Spent: 1h 20m (was: 1h 10m)
> MetricsPusherTest.pushesSystemMetrics is failing on non-portability
> FlinkRunner
> -------------------------------------------------------------------------------
>
> Key: BEAM-8869
> URL: https://issues.apache.org/jira/browse/BEAM-8869
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, test-failures
> Reporter: Kenneth Knowles
> Assignee: Michal Walenia
> Priority: Critical
> Labels: currently-failing
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Started right when it was merged:
> [https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/5971/]
> Recent:
> [https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/5986/]
> {code:java}
> java.lang.AssertionError:
> Expected: is <false>
> but: was <true>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
> at org.junit.Assert.assertThat(Assert.java:966)
> at org.junit.Assert.assertThat(Assert.java:931)
> at
> org.apache.beam.runners.core.metrics.MetricsPusherTest.pushesSystemMetrics(MetricsPusherTest.java:89)
> {code}
> The assertion is:
> {code:java}
> assertThat(TestMetricsSink.getSystemCounters().isEmpty(), is(false));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
