[
https://issues.apache.org/jira/browse/BEAM-8882?focusedWorklogId=354513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354513
]
ASF GitHub Bot logged work on BEAM-8882:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 17:43
Start Date: 05/Dec/19 17:43
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10292: [BEAM-8882]
Fully populate log messages.
URL: https://github.com/apache/beam/pull/10292#discussion_r354450210
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -1036,7 +1036,7 @@ def create(factory, transform_id, transform_proto,
parameter, consumers):
[WindowedValueCoder(source.default_output_coder())])
return factory.augment_oldstyle_op(
operations.ReadOperation(
- transform_proto.unique_name,
+ common.NameContext(transform_proto.unique_name, transform_id),
spec,
factory.counter_factory,
factory.state_sampler),
Review comment:
(this is the closest to the line that I could comment on)
It seems like the transform id/name context is not being propagated through
for the ImpulseReadOperation. Should we do it there for consistency as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 354513)
Time Spent: 2h 10m (was: 2h)
> Allow Dataflow to automatically choose portability or not.
> ----------------------------------------------------------
>
> Key: BEAM-8882
> URL: https://issues.apache.org/jira/browse/BEAM-8882
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Critical
> Fix For: 2.18.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> We would like the Dataflow service to be able to automatically choose whether
> to run pipelines in a portable way. In order to do this, we need to provide
> more information even if portability is not explicitly requested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
