[
https://issues.apache.org/jira/browse/BEAM-8846?focusedWorklogId=354795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354795
]
ASF GitHub Bot logged work on BEAM-8846:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 23:47
Start Date: 05/Dec/19 23:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10242: [BEAM-8846]
Force synchronization of the stream observer in BeamFnControlClient
URL: https://github.com/apache/beam/pull/10242#discussion_r354605342
##########
File path:
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/stream/OutboundObserverFactory.java
##########
@@ -28,15 +28,17 @@
public abstract class OutboundObserverFactory {
/**
* Create a buffering {@link OutboundObserverFactory} for client-side RPCs
with the specified
- * {@link ExecutorService} and the default buffer size.
+ * {@link ExecutorService} and the default buffer size. It adds
synchronization to provide thread
+ * safety of access to the returned observer.
*/
public static OutboundObserverFactory clientBuffered(ExecutorService
executorService) {
return new Buffered(executorService, Buffered.DEFAULT_BUFFER_SIZE);
}
/**
* Create a buffering {@link OutboundObserverFactory} for client-side RPCs
with the specified
- * {@link ExecutorService} and buffer size.
+ * {@link ExecutorService} and buffer size. It adds synchronization to
provide thread safety of
Review comment:
```suggestion
* {@link ExecutorService} and buffer size. All {@link StreamObserver}s
* created by this factory are thread safe.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 354795)
Time Spent: 2h 10m (was: 2h)
> Force synchronization of the stream observer in BeamFnControlClient
> -------------------------------------------------------------------
>
> Key: BEAM-8846
> URL: https://issues.apache.org/jira/browse/BEAM-8846
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Affects Versions: 2.18.0
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently there is no synchronization to access the stream observer in
> BeamFnControlClient which is not thread safe. We should fix it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
