[
https://issues.apache.org/jira/browse/BEAM-8901?focusedWorklogId=355044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355044
]
ASF GitHub Bot logged work on BEAM-8901:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/19 09:19
Start Date: 06/Dec/19 09:19
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10303: [BEAM-8901] add
experimental flag for reusing flink local environment
URL: https://github.com/apache/beam/pull/10303#discussion_r354729052
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -77,7 +81,16 @@ static ExecutionEnvironment createBatchExecutionEnvironment(
// depending on the master, create the right environment.
if ("[local]".equals(flinkMasterHostPort)) {
- flinkBatchEnv =
ExecutionEnvironment.createLocalEnvironment(flinkConfiguration);
+ if (ExperimentalOptions.hasExperiment(
+ options.as(ExperimentalOptions.class),
"reuseFlinkLocalExecutionEnvironment")) {
+ if (singletonLocalBatchEnvironment == null) {
+ singletonLocalBatchEnvironment =
+ ExecutionEnvironment.createLocalEnvironment(flinkConfiguration);
+ }
+ flinkBatchEnv = singletonLocalBatchEnvironment;
+ } else {
+ flinkBatchEnv =
ExecutionEnvironment.createLocalEnvironment(flinkConfiguration);
Review comment:
Is this only an issue for batch and not for streaming?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 355044)
Time Spent: 0.5h (was: 20m)
> add experimental flag for reusing flink local environment
> ---------------------------------------------------------
>
> Key: BEAM-8901
> URL: https://issues.apache.org/jira/browse/BEAM-8901
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Flink job server launches a new mini cluster every time we run the pipeline
> on Flink local environment. To prevent OOM, we need to reuse existing Flink
> local environment if possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)