[
https://issues.apache.org/jira/browse/BEAM-8902?focusedWorklogId=355383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355383
]
ASF GitHub Bot logged work on BEAM-8902:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/19 18:46
Start Date: 06/Dec/19 18:46
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10305: [BEAM-8902]
parameterize input type of Java external transform
URL: https://github.com/apache/beam/pull/10305#discussion_r354977354
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ExternalTest.java
##########
@@ -139,7 +139,7 @@ public void expandPythonTest() {
testPipeline
.apply(Create.of("1", "2", "2", "3", "3", "3"))
.apply(
- External.<KV<String, Integer>>of(
+ External.<PCollection<String>, KV<String, Integer>>of(
Review comment:
From a usability point of view, is it possible to infer this first type
argument (as it must match the input type)? Presumably we were inferring String
before...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 355383)
Time Spent: 0.5h (was: 20m)
> parameterize input type of Java external transform
> --------------------------------------------------
>
> Key: BEAM-8902
> URL: https://issues.apache.org/jira/browse/BEAM-8902
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> parameterize input type of Java external transform to allow multiple
> pcollections like PCollectionTuple or PCollectionList.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
