[
https://issues.apache.org/jira/browse/BEAM-8337?focusedWorklogId=356088&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356088
]
ASF GitHub Bot logged work on BEAM-8337:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/19 11:22
Start Date: 09/Dec/19 11:22
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10272: [BEAM-8337]
publish Flink job server container images
URL: https://github.com/apache/beam/pull/10272#discussion_r355394534
##########
File path: website/src/contribute/release-guide.md
##########
@@ -691,6 +691,15 @@ done
./gradlew :sdks:go:container:dockerPush -Pdocker-tag=${RELEASE}_rc{RC_NUM}
```
+* Build Flink job server images and push to DockerHub.
+
+```
+FLINK_VER=("1.7", "1.8", "1.9")
Review comment:
>My workspace contains directories runners/flink/1.5 and 1.6. I think we
might be better off hard-coding it.
That would be incorrect in case of a release. You need to clone the
directory to receive a clean checkout.
>I would incline towards hardcoding and if possible have a separate
validation in the release guide or a test to make sure we produce output for
the right versions.
This will produce the right output. If you have stale directories it will
fail which is correct.
There are pro and cos to both variants, but I'd say the risk is higher that
we forget to update this list, than the script returning something incorrect,
which should always lead to a failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 356088)
Time Spent: 2h 40m (was: 2.5h)
> Add Flink job server container images to release process
> --------------------------------------------------------
>
> Key: BEAM-8337
> URL: https://issues.apache.org/jira/browse/BEAM-8337
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Could be added to the release process similar to how we now publish SDK
> worker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
