[ 
https://issues.apache.org/jira/browse/BEAM-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992725#comment-16992725
 ] 

Maximilian Michels commented on BEAM-8274:
------------------------------------------

I still think that adding an undocumented experimental flag is not what we 
would expect from a portability layer to run properly. This flag should be 
removed entirely. Instead, a new flag can be added for backends which require 
Proto not in lines with the mainline portability.

> Remove dependency on experiments=beam_fn_api flag from PortableRunner
> ---------------------------------------------------------------------
>
>                 Key: BEAM-8274
>                 URL: https://issues.apache.org/jira/browse/BEAM-8274
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Maximilian Michels
>            Priority: Major
>
> The execution path of Python's {{PortableRunner}} depends on the 
> {{experiments=beam_fn_api}} flag. This flag is set automatically but has been 
> broken in the past, e.g. when the {{FlinkRunner}} was subclassed from the 
> {{PortableRunner}} (BEAM-8037).
> We should get rid of the flag, as the only supported execution path for the 
> PortableRunner is the BeamFnApi. Perhaps we can move the flag to the Dataflow 
> runners which may still depend on it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to