[ 
https://issues.apache.org/jira/browse/BEAM-8920?focusedWorklogId=357876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357876
 ]

ASF GitHub Bot logged work on BEAM-8920:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Dec/19 14:43
            Start Date: 11/Dec/19 14:43
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on issue #10349: [BEAM-8920] Go SDK: 
faster transforms/filter.Distinct with CombinePerKey
URL: https://github.com/apache/beam/pull/10349#issuecomment-564576278
 
 
   LGTM
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 357876)
    Time Spent: 0.5h  (was: 20m)

> Go SDK: faster transforms/filter.Distinct with CombinePerKey
> ------------------------------------------------------------
>
>                 Key: BEAM-8920
>                 URL: https://issues.apache.org/jira/browse/BEAM-8920
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: D. Yang
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The current implementation:
> 1. add fixed value 1: P<T> --> P<<T, 1>>
> 2. group by key: P<<T, 1>> --> GBK<T, 1>
> 3. drop the value: P<distinct T>
> The new proposed implementation:
> 1. ditto
> 2. combine by key: P<<T, 1>> --> P<<distinct T, 1>>
> 3. ditto
> CombinePerKey performs a pre-GBK ParDo, which is useful to reduce the shuffle 
> size.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to