[ 
https://issues.apache.org/jira/browse/BEAM-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomo Suzuki updated BEAM-8911:
------------------------------
    Description: 
Now [BEAM-8822] Hadoop client version 2.8.5 from 2.7 is merged. It's time to 
upgrade Guava.

h1. New Guava version: 25.1-jre
CharMatcher.DIGIT, used by  
org.apache.cassandra.io.sstable.format.SSTableFormat, is removed since Guava 
26.0. 25.1 is the latest version:

https://guava.dev/releases/25.1-jre/api/docs/com/google/common/base/CharMatcher.html
https://guava.dev/releases/26.0-jre/api/docs/com/google/common/base/CharMatcher.html

Guava has 2 variations "-jre" for Java8 (stream/lambda support) and "-android" 
for Java7. Gcsio:1.9.16, which Beam has not have in dependency tree yet, needs 
ImmutableSet.toImmutableSet() which is available in Guava "-jre".

https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1028#issuecomment-557680928


h2. What about upgrading Cassandra-all?

The latest cassandra-all release is "4.0-alpha2", which is still alpha. This 
version depends on guava 27.0-jre 
([link|https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/4.0-alpha2/jar]).

Non-alpha version is 3.11.5 
https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/3.11.5/jar,
 which still relies on Guava 19 and it still has reference to DIGIT:

{noformat}
suztomo@suxtomo24:~/grpc-java$ javap -v -cp 
~/Downloads/cassandra-all-3.11.5.jar 
'org.apache.cassandra.io.sstable.format.SSTableFormat$Type' |grep DIGIT
    #9 = Fieldref           #79.#80       // 
com/google/common/base/CharMatcher.DIGIT:Lcom/google/common/base/CharMatcher;
   #80 = NameAndType        #110:#111     // 
DIGIT:Lcom/google/common/base/CharMatcher;
  #110 = Utf8               DIGIT
{noformat}

Guava 19 has [digit() 
method|https://guava.dev/releases/19.0/api/docs/com/google/common/base/CharMatcher.html#digit()].




  was:
Now [BEAM-8822] Hadoop client version 2.8.5 from 2.7 is merged. It's time to 
upgrade Guava.

h1. New Guava version: 25.1-jre
CharMatcher.DIGIT, used by  
org.apache.cassandra.io.sstable.format.SSTableFormat, is removed since Guava 
26.0. 25.1 is the latest version:

https://guava.dev/releases/25.1-jre/api/docs/com/google/common/base/CharMatcher.html
https://guava.dev/releases/26.0-jre/api/docs/com/google/common/base/CharMatcher.html

Guava has 2 variations "-jre" for Java8 (stream/lambda support) and "-android" 
for Java7. Gcsio:1.9.16, which Beam has not have in dependency tree yet, needs 
ImmutableSet.toImmutableSet() which is available in Guava "-jre".

https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1028#issuecomment-557680928


h2. What about upgrading Cassandra-all?

The latest cassandra-all release is "4.0-alpha2", which is still alpha. This 
version depends on guava 27.0-jre 
([link|https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/4.0-alpha2/jar]).

Non-alpha version is 3.11.5 
https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/3.11.5/jar,
 which still relies on Guava 19 and it still has reference to DIGIT:


{noformat}
suztomo@suxtomo24:~/grpc-java$ javap -v -cp 
~/Downloads/cassandra-all-3.11.5.jar 
'org.apache.cassandra.io.sstable.format.SSTableFormat$Type' |grep DIGIT
    #9 = Fieldref           #79.#80       // 
com/google/common/base/CharMatcher.DIGIT:Lcom/google/common/base/CharMatcher;
   #80 = NameAndType        #110:#111     // 
DIGIT:Lcom/google/common/base/CharMatcher;
  #110 = Utf8               DIGIT
{noformat}






> Upgrade Guava to 25
> -------------------
>
>                 Key: BEAM-8911
>                 URL: https://issues.apache.org/jira/browse/BEAM-8911
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Tomo Suzuki
>            Assignee: Tomo Suzuki
>            Priority: Major
>          Time Spent: 8h 40m
>  Remaining Estimate: 0h
>
> Now [BEAM-8822] Hadoop client version 2.8.5 from 2.7 is merged. It's time to 
> upgrade Guava.
> h1. New Guava version: 25.1-jre
> CharMatcher.DIGIT, used by  
> org.apache.cassandra.io.sstable.format.SSTableFormat, is removed since Guava 
> 26.0. 25.1 is the latest version:
> https://guava.dev/releases/25.1-jre/api/docs/com/google/common/base/CharMatcher.html
> https://guava.dev/releases/26.0-jre/api/docs/com/google/common/base/CharMatcher.html
> Guava has 2 variations "-jre" for Java8 (stream/lambda support) and 
> "-android" for Java7. Gcsio:1.9.16, which Beam has not have in dependency 
> tree yet, needs ImmutableSet.toImmutableSet() which is available in Guava 
> "-jre".
> https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1028#issuecomment-557680928
> h2. What about upgrading Cassandra-all?
> The latest cassandra-all release is "4.0-alpha2", which is still alpha. This 
> version depends on guava 27.0-jre 
> ([link|https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/4.0-alpha2/jar]).
> Non-alpha version is 3.11.5 
> https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/3.11.5/jar,
>  which still relies on Guava 19 and it still has reference to DIGIT:
> {noformat}
> suztomo@suxtomo24:~/grpc-java$ javap -v -cp 
> ~/Downloads/cassandra-all-3.11.5.jar 
> 'org.apache.cassandra.io.sstable.format.SSTableFormat$Type' |grep DIGIT
>     #9 = Fieldref           #79.#80       // 
> com/google/common/base/CharMatcher.DIGIT:Lcom/google/common/base/CharMatcher;
>    #80 = NameAndType        #110:#111     // 
> DIGIT:Lcom/google/common/base/CharMatcher;
>   #110 = Utf8               DIGIT
> {noformat}
> Guava 19 has [digit() 
> method|https://guava.dev/releases/19.0/api/docs/com/google/common/base/CharMatcher.html#digit()].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to