[
https://issues.apache.org/jira/browse/BEAM-8801?focusedWorklogId=359015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359015
]
ASF GitHub Bot logged work on BEAM-8801:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/19 23:34
Start Date: 12/Dec/19 23:34
Worklog Time Spent: 10m
Work Description: milantracy commented on pull request #10359:
[BEAM-8801] PubsubMessageToRow should not check useFlatSchema() in pr…
URL: https://github.com/apache/beam/pull/10359#discussion_r357424068
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubMessageToRowTest.java
##########
@@ -131,12 +137,7 @@ public void testSendsInvalidToDLQ() {
message(4, map("bttr", "vbl"), "{ \"name\" : \"baz\",
\"id\" : 5 }")))
.apply(
"convert",
- ParDo.of(
- PubsubMessageToRow.builder()
- .messageSchema(messageSchema)
- .useDlq(true)
- .useFlatSchema(false)
- .build())
Review comment:
I agree that it would be better to test against PubsubMessageToRow.
I am curious whether you have any idea how PubsubIO could be mocked or not
given it is a private class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 359015)
Time Spent: 1.5h (was: 1h 20m)
> PubsubMessageToRow should not check useFlatSchema() in processElement
> ---------------------------------------------------------------------
>
> Key: BEAM-8801
> URL: https://issues.apache.org/jira/browse/BEAM-8801
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Brian Hulette
> Assignee: Jing Chen
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently we check useFlatSchema() for every element that's processed.
> Instead, we should check it once at pipeline construction time. See
> [comment|https://github.com/apache/beam/pull/10158#discussion_r348805530].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
