[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=359041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359041
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/19 00:26
Start Date: 13/Dec/19 00:26
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #10368: [BEAM-8335]
Modify PipelineInstrument to add TestStream for unbounded PCollections
URL: https://github.com/apache/beam/pull/10368#discussion_r357435714
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -375,12 +377,15 @@ def _read_cache(self, pipeline, pcoll):
# Can only read from cache when the cache with expected key exists.
if self._cache_manager.exists('full', key):
if key not in self._cached_pcoll_read:
+ if pcoll.is_bounded:
+ read_transform = cache.ReadCache(self._cache_manager, key)
+ else:
+ read_transform = streaming_cache.StreamingCacheReceiver()
Review comment:
Yes, I think this works for most scenarios. Do you remember I used to check
the source `is_bounded` field when checking if a pipeline has unbounded source?
Then we switched to check if a pipeline contains known unbounded sources.
It's the same thing here.
Unless we change the implementation of `is_bounded` to cover all possible
sources, we can never be sure if the `is_bounded` is the source of truth.
We have these questions to answer:
- Does all source implementation inherit the `apache_beam/io/iobase.py`?
- And even if they do, does all the unbounded source implementation put a
`False` value in the `is_bounded` member in their source code? Is there any
enforcement for that except code review?
- Can there be unbounded source dynamically created without source code?
I think this is equivalent to checking if a given pipeline has unbounded
source.
If we cannot be sure there (for example, user-defined unknown sources with
arbitrary definition) since we only check known unbounded sources, we cannot be
sure here either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 359041)
Time Spent: 46h 40m (was: 46.5h)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 46h 40m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
