[
https://issues.apache.org/jira/browse/BEAM-8917?focusedWorklogId=359501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359501
]
ASF GitHub Bot logged work on BEAM-8917:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/19 16:55
Start Date: 13/Dec/19 16:55
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #10324: [BEAM-8917] jsr305
dependency declaration for Nullable class
URL: https://github.com/apache/beam/pull/10324#issuecomment-565516004
Just double checked with today's SNAPSHOTs after the merge and the pom of
core is not modified, however the deps look good in master, not sure if the
change was applied before the SNAPSHOT generation, but still to double check.
https://repository.apache.org/content/repositories/snapshots/org/apache/beam/beam-sdks-java-core/2.19.0-SNAPSHOT/beam-sdks-java-core-2.19.0-20191213.072102-9.pom
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 359501)
Time Spent: 10h 50m (was: 10h 40m)
> javax.annotation.Nullable is missing for
> org.apache.beam.sdk.schemas.FieldValueTypeInformation
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-8917
> URL: https://issues.apache.org/jira/browse/BEAM-8917
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> This ticket is from the result of static analysis by Linkage Checker
> ([detail|https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1045])
> h1. Example Project
> Example project to produce an issue:
> https://github.com/suztomo/beam-java-sdk-missing-nullable .
> I think the Maven artifact {{org.apache.beam:beam-sdks-java-core}}, which
> contains {{org.apache.beam.sdk.schemas.FieldValueTypeInformation}}, should
> declare the dependency to {{com.google.code.findbugs:jsr305}}.
> h1. Why there's no problem in compilation and tests of sdks/java/core?
> The compilation succeeds because the {{Nullable}} annotation is in the
> transitive dependency of compileOnly {{spotbugs-annotations}} dependency:
> {noformat}
> compileOnly - Compile only dependencies for source set 'main'.
> ...
> +--- com.github.spotbugs:spotbugs-annotations:3.1.12
> | \--- com.google.code.findbugs:jsr305:3.0.2
> ...
> {noformat}
> The tests succeed because the {{Nullable}} annotation is in the transitive
> dependency of {{guava-testlib}}.
> {noformat}
> testRuntime - Runtime dependencies for source set 'test' (deprecated, use
> 'testRuntimeOnly' instead).
> ...
> +--- com.google.guava:guava-testlib:20.0
> | +--- com.google.code.findbugs:jsr305:1.3.9
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
