[
https://issues.apache.org/jira/browse/BEAM-8536?focusedWorklogId=360577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360577
]
ASF GitHub Bot logged work on BEAM-8536:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/19 23:11
Start Date: 16/Dec/19 23:11
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #10333: [BEAM-8536]
Migrate request_execution_time to request_delay_time in Java
URL: https://github.com/apache/beam/pull/10333#discussion_r358515080
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -207,18 +207,13 @@ message BundleApplication {
// Either an absolute timestamp or a relative timestamp can represent a
// scheduled execution time.
message DelayedBundleApplication {
- // Recommended time at which the application should be scheduled to execute
- // by the runner. Times in the past may be scheduled to execute immediately.
- // TODO(BEAM-8536): Migrate usage of absolute time to requested_time_delay.
- google.protobuf.Timestamp requested_execution_time = 1;
Review comment:
I have changed all usages in this PR. Just talked to Rebo and Daniel, one
thing left here is to generate go proto within this PR. I'll let you know once
I finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 360577)
Time Spent: 1h 20m (was: 1h 10m)
> Migrate usage of DelayedBundleApplication.requested_execution_time to time
> duration
> ------------------------------------------------------------------------------------
>
> Key: BEAM-8536
> URL: https://issues.apache.org/jira/browse/BEAM-8536
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow, sdk-java-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In DelayedBundleApplication, we used to use an absolute time to represent
> rescheduling time. We want to switch to use a relative time duration, which
> requires a migration in Java SDK and dataflow java runner harness.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
