[
https://issues.apache.org/jira/browse/BEAM-5495?focusedWorklogId=361105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361105
]
ASF GitHub Bot logged work on BEAM-5495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/19 21:02
Start Date: 17/Dec/19 21:02
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10268: [BEAM-5495]
PipelineResources algorithm is not working in most environments
URL: https://github.com/apache/beam/pull/10268#discussion_r359017865
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/resources/PipelineResourcesDetector.java
##########
@@ -18,10 +18,10 @@
package org.apache.beam.runners.core.construction.resources;
import java.io.Serializable;
-import java.util.List;
+import java.util.stream.Stream;
/** Interface for an algorithm detecting classpath resources for pipelines. */
public interface PipelineResourcesDetector extends Serializable {
- List<String> detect(ClassLoader classLoader);
+ Stream<String> detect(ClassLoader classLoader);
Review comment:
I would have also preferred list since stream can imply that it is
infinitely long since there could be a generator function the person
implements. Lists are ordered and have finite size.
Also, set is the wrong abstraction since we want to maintain the classpath
order and we also want to maintain duplicates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 361105)
Time Spent: 14h 40m (was: 14.5h)
> PipelineResources algorithm is not working in most environments
> ---------------------------------------------------------------
>
> Key: BEAM-5495
> URL: https://issues.apache.org/jira/browse/BEAM-5495
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, runner-spark, sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Lukasz Gajowy
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 14h 40m
> Remaining Estimate: 0h
>
> Issue are:
> 1. it assumes the classloader is an URLClassLoader (not always true and java
> >= 9 breaks that as well for the app loader)
> 2. it uses loader.getURLs() which leads to including the JRE itself in the
> staged file
> Looks like this detect resource algorithm can't work and should be replaced
> by a SPI rather than a built-in and not extensible algorithm. Another valid
> alternative is to just drop that "guess" logic and force the user to set
> staged files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
