[
https://issues.apache.org/jira/browse/BEAM-7850?focusedWorklogId=361188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361188
]
ASF GitHub Bot logged work on BEAM-7850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/19 23:01
Start Date: 17/Dec/19 23:01
Worklog Time Spent: 10m
Work Description: youngoli commented on issue #10183: [BEAM-7850] Makes
environment ID a top level attribute of PTransform.
URL: https://github.com/apache/beam/pull/10183#issuecomment-566788122
Heads up, in #10393 I updated the Go proto compiler version and rebuilt the
generated code.You'll probably need to update the generated Go code before
merging this (and make sure you update the protoc-gen-go version to the most
recent one this time). If it says the generated code is using ProtoVersion3
instead of 2, then your change is good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 361188)
Time Spent: 2h 40m (was: 2.5h)
> Make Environment a top level attribute of PTransform
> ----------------------------------------------------
>
> Key: BEAM-7850
> URL: https://issues.apache.org/jira/browse/BEAM-7850
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently Environment is not a top level attribute of the PTransform (of
> runner API proto).
> [https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/beam_runner_api.proto#L99]
> Instead it is hidden inside various payload objects. For example, for ParDo,
> environment will be inside SdkFunctionSpec of ParDoPayload.
> [https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/beam_runner_api.proto#L99]
>
> This makes tracking environment of different types of PTransforms harder and
> we have to fork code (on the type of PTransform) to extract the Environment
> where the PTransform should be executed. It will probably be simpler to just
> make Environment a top level attribute of PTransform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
