[
https://issues.apache.org/jira/browse/BEAM-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000153#comment-17000153
]
Lukasz Gajowy edited comment on BEAM-7245 at 12/19/19 3:58 PM:
---------------------------------------------------------------
[~mwalenia] should we close this ticket?
was (Author: łukaszg):
[~mwalenia] is this ticket finished?
> Encapsulate supplier, monitor and metric naming logic in some common
> TestMetric type
> -------------------------------------------------------------------------------------
>
> Key: BEAM-7245
> URL: https://issues.apache.org/jira/browse/BEAM-7245
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Lukasz Gajowy
> Priority: Minor
>
> After an offline discussion together with @mwalenia we decided to create
> concrete classes for each metric type (Item_count, byte_count, time). Each
> class like this will contain:
> - metric name
> - supplier for the metric
> - monitor for the metric
> It turns out that all this (along with the monitor/supplier can be
> encapsulated and then attached to the pipeline/metrics reading where needed.
> This will also encapsulate the naming logic (so that there are no typos
> again).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
