[
https://issues.apache.org/jira/browse/BEAM-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999527#comment-16999527
]
Tomo Suzuki edited comment on BEAM-8695 at 12/19/19 9:11 PM:
-------------------------------------------------------------
https://builds.apache.org/job/beam_PreCommit_Java_Commit/9288/#showFailuresLink
{noformat}
org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapperTest$ParameterizedUnboundedSourceWrapperTest.testWatermarkEmission[numTasks
= 2; numSplits=2]
org.apache.beam.runners.dataflow.worker.fn.control.ElementCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.ElementCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MSecMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMSecMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MSecMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMSecMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MeanByteCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MeanByteCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserDistributionMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserDistributionMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodeSuccessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForLengthPrefixCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForSideInputInfos
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixParDoInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixInstructionOutputCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixWriteInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceUnknownCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceForRunnerNetwork
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodePredecessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixReadInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodeSuccessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForLengthPrefixCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForSideInputInfos
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixParDoInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixInstructionOutputCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixWriteInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceUnknownCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceForRunnerNetwork
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodePredecessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixReadInstructionCoder
org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOReadTest.testEstimatedSizeWithoutStreamingBuffer
org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOReadTest.testEstimatedSizeWithStreamingBuffer
org.apache.beam.sdk.io.gcp.bigquery.BigQueryUtilTest.testInsertAll
{noformat}
For org.apache.beam.runners.dataflow.worker.fn.control package, most of them
are comparison failure.
{noformat}
expected:
<[
{cumulative=true,
integer={highBits=0, lowBits=0},
nameAndKind={kind=SUM, name=transformedValue-ElementCount]}}>
but was:
<[GenericData{classInfo=[boolean, cumulative, distribution, floatingPoint,
floatingPointList, floatingPointMean, integer, integerGauge, integerList,
integerMean, internal, nameAndKind, shortId, stringList,
structuredNameAndMetadata],
{cumulative=true,
integer=GenericData{classInfo=[highBits, lowBits], {highBits=0, lowBits=0}},
nameAndKind=GenericData{classInfo=[kind, name], {kind=SUM,
name=transformedValue-ElementCount}}]}}>
{noformat}
The closing braces in the expected value seems wrong.
The values look same but the actual value carries class information
"GenericData". Where is this "GenericData" coming from?
{noformat}
CounterUpdate result = testObject.transform(monitoringInfo);
assertNotEquals(null, result);
assertEquals(
"{cumulative=true, integer={highBits=0, lowBits=0}, "
+ "nameAndKind={kind=SUM, "
+ "name=transformedValue-ElementCount}}",
result.toString());
{noformat}
In google-http-client 1.34.0, {{GenericData.toString()}} returns
{{"GenericData..."}}. Behavioral change... It should compare objects, not
strings. How can I create GenericJson in these tests easily?
was (Author: suztomo):
https://builds.apache.org/job/beam_PreCommit_Java_Commit/9288/#showFailuresLink
{noformat}
org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapperTest$ParameterizedUnboundedSourceWrapperTest.testWatermarkEmission[numTasks
= 2; numSplits=2]
org.apache.beam.runners.dataflow.worker.fn.control.ElementCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.ElementCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MSecMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMSecMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MSecMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMSecMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MeanByteCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.MeanByteCountMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserDistributionMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserDistributionMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.fn.control.UserMonitoringInfoToCounterUpdateTransformerTest.testTransformReturnsValidCounterUpdateWhenValidUserMonitoringInfoReceived
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodeSuccessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForLengthPrefixCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForSideInputInfos
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixParDoInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixInstructionOutputCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixWriteInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceUnknownCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceForRunnerNetwork
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodePredecessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixReadInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodeSuccessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForLengthPrefixCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForSideInputInfos
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixParDoInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixInstructionOutputCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixWriteInstructionCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceUnknownCoder
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceForRunnerNetwork
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodePredecessor
org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixReadInstructionCoder
org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOReadTest.testEstimatedSizeWithoutStreamingBuffer
org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOReadTest.testEstimatedSizeWithStreamingBuffer
org.apache.beam.sdk.io.gcp.bigquery.BigQueryUtilTest.testInsertAll
{noformat}
Most of them are comparison failure.
{noformat}
expected:
<[
{cumulative=true,
integer={highBits=0, lowBits=0},
nameAndKind={kind=SUM, name=transformedValue-ElementCount]}}>
but was:
<[GenericData{classInfo=[boolean, cumulative, distribution, floatingPoint,
floatingPointList, floatingPointMean, integer, integerGauge, integerList,
integerMean, internal, nameAndKind, shortId, stringList,
structuredNameAndMetadata],
{cumulative=true,
integer=GenericData{classInfo=[highBits, lowBits], {highBits=0, lowBits=0}},
nameAndKind=GenericData{classInfo=[kind, name], {kind=SUM,
name=transformedValue-ElementCount}}]}}>
{noformat}
The closing braces in the expected value seems wrong.
The values look same but the actual value carries class information
"GenericData". Where is this "GenericData" coming from?
{noformat}
CounterUpdate result = testObject.transform(monitoringInfo);
assertNotEquals(null, result);
assertEquals(
"{cumulative=true, integer={highBits=0, lowBits=0}, "
+ "nameAndKind={kind=SUM, "
+ "name=transformedValue-ElementCount}}",
result.toString());
{noformat}
In google-http-client 1.34.0, {{GenericData.toString()}} returns
{{"GenericData..."}}. Behavioral change... It should compare objects, not
strings. How can I create GenericJson in these tests easily?
> Beam Dependency Update Request: com.google.http-client:google-http-client
> -------------------------------------------------------------------------
>
> Key: BEAM-8695
> URL: https://issues.apache.org/jira/browse/BEAM-8695
> Project: Beam
> Issue Type: Sub-task
> Components: dependencies
> Reporter: Beam JIRA Bot
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ------------------------- 2019-11-15 19:40:13.570557
> -------------------------
> Please consider upgrading the dependency
> com.google.http-client:google-http-client.
> The current version is 1.28.0. The latest version is 1.33.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-11-19 21:06:20.477284
> -------------------------
> Please consider upgrading the dependency
> com.google.http-client:google-http-client.
> The current version is 1.28.0. The latest version is 1.33.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-12-02 12:12:12.146269
> -------------------------
> Please consider upgrading the dependency
> com.google.http-client:google-http-client.
> The current version is 1.28.0. The latest version is 1.33.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-12-09 12:11:24.693912
> -------------------------
> Please consider upgrading the dependency
> com.google.http-client:google-http-client.
> The current version is 1.28.0. The latest version is 1.33.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
