[ 
https://issues.apache.org/jira/browse/BEAM-9012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001300#comment-17001300
 ] 

Brian Hulette commented on BEAM-9012:
-------------------------------------

My motivation: we use pytype internally at Google. Some teams are already 
running pytype on code that uses beam python. Before we had type hints it just 
happily ignored the beam code, but with the change some errors are cropping up. 
You have a good point that it could be a slippery slope to promise full pytype 
support... but so far across a lot of different code this is actually the only 
issue that's come up.

> Include `-> None` on Pipeline and PipelineOptions `__init__` methods for 
> pytype compatibility
> ---------------------------------------------------------------------------------------------
>
>                 Key: BEAM-9012
>                 URL: https://issues.apache.org/jira/browse/BEAM-9012
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: Major
>             Fix For: 2.19.0
>
>
> mypy [made a decision|https://github.com/python/mypy/issues/604] to allow 
> init methods to omit {{\-> None}} return type annotations, but pytype has no 
> such feature. I think we should include {{\-> None}} annotations for pytype 
> compatibility.
> cc: [~chadrik]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to