[
https://issues.apache.org/jira/browse/BEAM-8962?focusedWorklogId=362436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362436
]
ASF GitHub Bot logged work on BEAM-8962:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 06:51
Start Date: 23/Dec/19 06:51
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #10415: [BEAM-8962]
Report Flink metric accumulator only when pipeline ends
URL: https://github.com/apache/beam/pull/10415#discussion_r360783499
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkStatefulDoFnFunction.java
##########
@@ -227,12 +224,14 @@ public void open(Configuration parameters) {
// deserialization method. However, this is a hack, and we want to
properly initialize the
// options where they are needed.
FileSystems.setDefaultPipelineOptions(serializedOptions.get());
+ metricContainer = new FlinkMetricContainer(getRuntimeContext());
doFnInvoker = DoFnInvokers.tryInvokeSetupFor(dofn);
}
@Override
public void close() throws Exception {
try {
+ metricContainer.registerMetricsForPipelineResult();
Review comment:
Is it guaranteed that the accumulators created in `close` will be captured
in the terminated Flink job? Is it covered by existing tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362436)
Time Spent: 1h 50m (was: 1h 40m)
> FlinkMetricContainer causes churn in the JobManager and lets the web frontend
> malfunction
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-8962
> URL: https://issues.apache.org/jira/browse/BEAM-8962
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The {{FlinkMetricContainer}} wraps the Beam metric container for reporting
> metrics, but also stores them as Flink accumulators. With high parallelism
> jobs with over a thousand tasks and many built-in Beam metrics for every Beam
> step, this can accumulate to over 100MB of serialized data which is stored in
> the JobManager's ExecutionGraph. This then fails to even sent over the wire,
> due to the akka.framesize limit (10MB by default), and manifests in {{500
> Internal Server Error}}s in the web frontend.
> We need to introduce an option to disable the reporting via accumulators. It
> is mostly useful for batch workloads where you can retrieve the final
> accumulator values at the end of the job. It adds a lot of memory and network
> overhead.
> Perhaps we could even turn off the accumulators for streaming jobs, or
> entirely and make them opt-in.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
