[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=362517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362517
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 12:36
Start Date: 23/Dec/19 12:36
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #10449:
[BEAM-7274] Implement the Protobuf schema provider for compiled protocol buffers
URL: https://github.com/apache/beam/pull/10449#discussion_r360873653
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java
##########
@@ -122,6 +123,15 @@ private Iterable getIterableValue(FieldType elementType,
Object fieldValue) {
cacheKey, i -> getMapValue(type.getMapKeyType(),
type.getMapValueType(), map))
: (T) getMapValue(type.getMapKeyType(), type.getMapValueType(), map);
} else {
+ if (type.isLogicalType(OneOfType.IDENTIFIER)) {
Review comment:
My gut feeling says that we should take it separately. Ok, union types will
fail, but for now it's only proto specific right? I've added this on my todo
list when testing the implementation with our use cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362517)
Time Spent: 21h 10m (was: 21h)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 21h 10m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
