[
https://issues.apache.org/jira/browse/BEAM-9012?focusedWorklogId=364068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364068
]
ASF GitHub Bot logged work on BEAM-9012:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Dec/19 00:47
Start Date: 28/Dec/19 00:47
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on issue #10466: [BEAM-9012]
Change __init__ hints so they work with pytype
URL: https://github.com/apache/beam/pull/10466#issuecomment-569370384
> So why change it in these two places, since the per-line style is still
used in dozens of other places in the code?
Honestly, these were just the only two places where I personally encountered
an issue when running pytype on code that used beam. There may well be other
public `__init__` functions that pytype thinks aren't callable and we just
don't have code that exercises it.
Thanks for the clean up @udim :) Sorry I didn't get to it sooner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 364068)
Time Spent: 1h (was: 50m)
> Include `-> None` on Pipeline and PipelineOptions `__init__` methods for
> pytype compatibility
> ---------------------------------------------------------------------------------------------
>
> Key: BEAM-9012
> URL: https://issues.apache.org/jira/browse/BEAM-9012
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> mypy [made a decision|https://github.com/python/mypy/issues/604] to allow
> init methods to omit {{\-> None}} return type annotations, but pytype has no
> such feature. I think we should include {{\-> None}} annotations for pytype
> compatibility.
> cc: [~chadrik]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
