[
https://issues.apache.org/jira/browse/BEAM-9020?focusedWorklogId=364693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364693
]
ASF GitHub Bot logged work on BEAM-9020:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Dec/19 17:49
Start Date: 30/Dec/19 17:49
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10467: [BEAM-9020]
LengthPrefixUnknownCodersTest to avoid relying on AbstractMap's equality
URL: https://github.com/apache/beam/pull/10467#discussion_r362051797
##########
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/graph/LengthPrefixUnknownCodersTest.java
##########
@@ -252,11 +253,11 @@ public void testLengthPrefixAndReplaceForRunnerNetwork()
{
}
}
- Set expectedInstructions =
+ ImmutableSet<GenericJson> expectedInstructions =
ImmutableSet.of(
- prefixedReadNode.getParallelInstruction(),
prefixedReadNodeOut.getInstructionOutput());
+ prefixedReadNodeOut.getInstructionOutput(),
prefixedReadNode.getParallelInstruction());
Review comment:
The intent isn't to have a set in JSON but to match the expected vs the
received which is why set was being used instead of a list so this test was
attempting to do something like `assertThat(..., contains(...))`.
Please update this so that we don't care about the order of the nodes when
matching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 364693)
Time Spent: 40m (was: 0.5h)
> LengthPrefixUnknownCodersTest to avoid relying on AbstractMap's equality
> ------------------------------------------------------------------------
>
> Key: BEAM-9020
> URL: https://issues.apache.org/jira/browse/BEAM-9020
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Tomo Suzuki
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In an attempt for BEAM-8695 LengthPrefixUnknownCodersTest failed when trying
> to upgrade google-http-client v1.34.0, because LengthPrefixUnknownCodersTest
> relies on the equality of {{CloudObject}} with Map.
> Class hierarchy:
> {noformat}
> CloudObject < GenericJson < GenericData < AbstractMap
> {noformat}
> It was working fine as long as CloudObject's equality inherits
> AbstractMap.equality. {{GenericData}} did not override equals method in
> google-http-client v1.28.0 and earlier. The comparison was checking only key
> and value of a Map.
> {code:java}
> assertEquals(
> CloudObjects.asCloudObject(prefixedWindowedValueCoder, null), // This
> is a CloudObject
> lengthPrefixedCoderCloudObject); // This is a
> Map
> {code}
> However, with google-http-client v1.29.0 or higher, GenericData has its own
> {{equals}} method
> ([PR#589|https://github.com/googleapis/google-http-java-client/pull/589])
> that checks {{classInfo}} and thus the comparisons between a CloudObject and
> a Map always fail.
> Test failures when I tried to upgrade google-http-client 1.34.0
> ([Jenkins|https://builds.apache.org/job/beam_PreCommit_Java_Commit/9288/#showFailuresLink]):
> {noformat}
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodeSuccessor
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForLengthPrefixCoder
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForSideInputInfos
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixParDoInstructionCoder
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixInstructionOutputCoder
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixWriteInstructionCoder
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceUnknownCoder
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixAndReplaceForRunnerNetwork
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixForInstructionOutputNodeWithGrpcNodePredecessor
> org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest.testLengthPrefixReadInstructionCoder
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
