[
https://issues.apache.org/jira/browse/BEAM-7115?focusedWorklogId=365707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365707
]
ASF GitHub Bot logged work on BEAM-7115:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/20 07:29
Start Date: 03/Jan/20 07:29
Worklog Time Spent: 10m
Work Description: mwalenia commented on pull request #10460: [BEAM-7115]
Fix metrics being incorrectly gathered
URL: https://github.com/apache/beam/pull/10460#discussion_r362722807
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/tfrecord/TFRecordIOIT.java
##########
@@ -125,18 +125,19 @@ public void writeThenReadAll() {
.apply("Transform strings to bytes", MapElements.via(new
StringToByteArray()))
.apply(
"Record time before writing",
- ParDo.of(new TimeMonitor<>(TFRECORD_NAMESPACE, "writeTime")))
+ ParDo.of(new TimeMonitor<>(TFRECORD_NAMESPACE, "write_time")))
Review comment:
What do you think about extracting the string metric names to constants? In
case of a change it would be easier to manage the naming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 365707)
Time Spent: 40m (was: 0.5h)
> TFRecordIOIT write_time metrics are allways 0.0
> -----------------------------------------------
>
> Key: BEAM-7115
> URL: https://issues.apache.org/jira/browse/BEAM-7115
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Lukasz Gajowy
> Assignee: Pawel Pasterz
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Is it because the test is so small? Or the metric is not collected well?
> This is visible in the dashboards:
> [https://apache-beam-testing.appspot.com/explore?dashboard=5755685136498688]
> (look for TFRecordIOIT widget)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
