[ 
https://issues.apache.org/jira/browse/BEAM-9013?focusedWorklogId=366013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366013
 ]

ASF GitHub Bot logged work on BEAM-9013:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/20 20:41
            Start Date: 03/Jan/20 20:41
    Worklog Time Spent: 10m 
      Work Description: rohdesamuel commented on issue #10445: [BEAM-9013] 
TestStream fix for DataflowRunner
URL: https://github.com/apache/beam/pull/10445#issuecomment-570692052
 
 
   > Also, I thought the intent was to make all the 
`_WatermarkControllerEvaluator`, etc. an implementation detail (e.g. in the 
Direct runner) and let TestStream remain a primitive. It seems the right thing 
to do is keep TestStream a primitive and add Overrides for the Direct runner 
rather than add overrides to "undo" the DirectRunner implementation for the 
DataflowRunner. (I suspect this would also break Flink and any other runners 
that implemented TestStream the old way.)
   
   I moved the the multi-output TestStream implementation to the DirectRunner
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 366013)
    Time Spent: 1h 10m  (was: 1h)

> Multi-output TestStream breaks the DataflowRunner
> -------------------------------------------------
>
>                 Key: BEAM-9013
>                 URL: https://issues.apache.org/jira/browse/BEAM-9013
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>    Affects Versions: 2.17.0
>            Reporter: Sam Rohde
>            Assignee: Sam Rohde
>            Priority: Major
>             Fix For: 2.17.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to