[
https://issues.apache.org/jira/browse/BEAM-9049?focusedWorklogId=366072&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366072
]
ASF GitHub Bot logged work on BEAM-9049:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/20 22:42
Start Date: 03/Jan/20 22:42
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #10499: [BEAM-9049] Add
opt-in --shutDownOnThrashing flag
URL: https://github.com/apache/beam/pull/10499#issuecomment-570720118
> Good point, this will also turn off thrashing detection for Python in the
JRH, and as its written now there will be no way to opt-in because of
`@Hidden`. I think that's acceptable, I wouldn't imagine thrashing in the JVM
would be very likely for the JRH?
>
> We could also just remove the `@Hidden` but then that brings in several
other flags related to debugging java workers.
I agree, as we don't run custom code on JRH in python pipelines, JHR memory
thrashing would be unlikely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 366072)
Time Spent: 50m (was: 40m)
> Add knobs for dataflow worker MemoryMonitor
> -------------------------------------------
>
> Key: BEAM-9049
> URL: https://issues.apache.org/jira/browse/BEAM-9049
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> MemoryMonitor has many knobs that are just hard-coded for now. We should make
> some (or all) of these knobs available via pipeline options, so that users
> have control over when workers will be killed due to thrashing.
> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/MemoryMonitor.java#L123
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
