[
https://issues.apache.org/jira/browse/BEAM-8844?focusedWorklogId=366086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366086
]
ASF GitHub Bot logged work on BEAM-8844:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/20 23:20
Start Date: 03/Jan/20 23:20
Worklog Time Spent: 10m
Work Description: 11moon11 commented on pull request #10226: [BEAM-8844]
Add a new Jenkins job for SQL perf tests
URL: https://github.com/apache/beam/pull/10226#discussion_r362992351
##########
File path:
sdks/java/extensions/sql/perf-tests/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryPerfTableProvider.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.meta.provider.bigquery;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import static
org.apache.beam.vendor.calcite.v1_20_0.com.google.common.base.MoreObjects.firstNonNull;
+
+import org.apache.beam.sdk.extensions.sql.meta.BeamSqlTable;
+import org.apache.beam.sdk.extensions.sql.meta.Table;
+import org.apache.beam.sdk.io.gcp.bigquery.BigQueryUtils.ConversionOptions;
+import
org.apache.beam.sdk.io.gcp.bigquery.BigQueryUtils.ConversionOptions.TruncateTimestamps;
+
+/** A test table provider for BigQueryIOPushDownIT. */
+public class BigQueryPerfTableProvider extends BigQueryTableProvider {
+ private final String namespace;
+ private final String metric;
+
+ BigQueryPerfTableProvider(String namespace, String metric) {
+ super();
+ this.namespace = namespace;
+ this.metric = metric;
+ }
+
+ @Override
+ public BeamSqlTable buildBeamSqlTable(Table table) {
+ return new BigQueryPerfTable(
+ table,
+ ConversionOptions.builder()
Review comment:
Since building `ConversionOptions` requires access to the `Table`, created a
`protected static getConversionOptions(Table table)` method (in
`BigQueryTableProvider` class).
This way both classes will rely on the same code.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 366086)
Time Spent: 7h 10m (was: 7h)
> [SQL] Create performance tests for BigQueryTable
> ------------------------------------------------
>
> Key: BEAM-8844
> URL: https://issues.apache.org/jira/browse/BEAM-8844
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> They should measure read-time for:
> * DIRECT_READ w/o push-down
> * DIRECT_READ w/ push-down
> * DEFAULT
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
