[
https://issues.apache.org/jira/browse/BEAM-8951?focusedWorklogId=366922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366922
]
ASF GitHub Bot logged work on BEAM-8951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/20 20:05
Start Date: 06/Jan/20 20:05
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #10435: [BEAM-8951]
Stop using nose in load tests
URL: https://github.com/apache/beam/pull/10435#discussion_r363452643
##########
File path:
sdks/python/apache_beam/testing/load_tests/streaming/group_by_key_streaming_test.py
##########
@@ -62,12 +56,11 @@ def _add_argparse_args(cls, parser):
parser.add_argument('--test-pipeline-options')
[email protected](not load_test_enabled, 'Enabled only for phase triggering.')
class GroupByKeyStreamingTest(LoadTest):
ID_LABEL = 'id'
- def setUp(self):
- super(GroupByKeyStreamingTest, self).setUp()
+ def __init__(self):
+ super(GroupByKeyStreamingTest, self).__init__()
Review comment:
Does running these tests on Dataflow runner require --save_main_session?
Heads-up that there is https://issues.apache.org/jira/browse/BEAM-6158 which
may affect the execution on Python 3. Please check that we can run these tests
on Python 3 on Dataflow (you can check on any test that is supported by
Dataflow Runner).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 366922)
Time Spent: 3h 20m (was: 3h 10m)
> Stop using nose in load tests
> -----------------------------
>
> Key: BEAM-8951
> URL: https://issues.apache.org/jira/browse/BEAM-8951
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> The community is considering moving away from nose to pytest:
> https://issues.apache.org/jira/browse/BEAM-3713. We should change the way of
> running Python load tests: instead of being subclasses of
> `unittest.TestCase`, they could be plain Python scripts, just like wordcount
> examples. This will bring one additional benefit: _LOAD_TEST_ENABLED_ guard
> will be no longer needed and could be safely removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
