[
https://issues.apache.org/jira/browse/BEAM-9059?focusedWorklogId=368794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368794
]
ASF GitHub Bot logged work on BEAM-9059:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 03:10
Start Date: 09/Jan/20 03:10
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on pull request #10521:
[BEAM-9059] Use string constants in PTransformTranslation instead of getUrn()
URL: https://github.com/apache/beam/pull/10521#discussion_r364542265
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMappingFnRunner.java
##########
@@ -45,7 +44,7 @@
* to associate each input with its output. The nonce is represented as an
opaque set of bytes.
*/
public class WindowMappingFnRunner {
- static final String URN =
BeamUrns.getUrn(StandardPTransforms.Primitives.MAP_WINDOWS);
+ static final String URN = PTransformTranslation.MERGE_WINDOWS_TRANSFORM_URN;
Review comment:
should be `MAP_WINDOWS_TRANSFORM_URN`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 368794)
Time Spent: 3h 10m (was: 3h)
> Migrate PTransformTranslation to use string constants
> -----------------------------------------------------
>
> Key: BEAM-9059
> URL: https://issues.apache.org/jira/browse/BEAM-9059
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Trivial
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> This allows for the values to be used within switch case statements.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
