[
https://issues.apache.org/jira/browse/BEAM-8932?focusedWorklogId=369128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369128
]
ASF GitHub Bot logged work on BEAM-8932:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 16:19
Start Date: 09/Jan/20 16:19
Worklog Time Spent: 10m
Work Description: dpcollins-google commented on issue #10476:
[BEAM-8932][Cleanup] Move external PubsubIO hooks outside of PubsubIO.
URL: https://github.com/apache/beam/pull/10476#issuecomment-572635314
> > Also fix these so that they typecheck correctly without relying on java
runtime duck typing.
>
> Could you explain what you changed with regards to this?
Previously, these classes were inside a generic context with a parameter
type of the builder, but they would have thrown an exception due to a bad cast
if they were used with any type other than byte[]. This makes it explicit that
the output type of the PTransform is a byte[] and removes some unsafe casts
that were only correct if the output type is a byte[].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 369128)
Time Spent: 10h 10m (was: 10h)
> Expose complete Cloud Pub/Sub messages through PubsubIO API
> -----------------------------------------------------------
>
> Key: BEAM-8932
> URL: https://issues.apache.org/jira/browse/BEAM-8932
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Daniel Collins
> Assignee: Daniel Collins
> Priority: Major
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> The PubsubIO API only exposes a subset of the fields in the underlying
> PubsubMessage protocol buffer. To accomodate future feature changes as well
> as for greater compatability with code using the Cloud Pub/Sub apis, a method
> to read and write these protocol messages should be exposed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
