[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=369264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369264
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 19:01
Start Date: 09/Jan/20 19:01
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364908479
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -437,13 +439,15 @@ def invoke_start_bundle(self):
# type: () -> None
"""Invokes the DoFn.start_bundle() method.
"""
+ assert self.output_processor is not None
Review comment:
These asserts should be fast, but have you verified this doesn't impact
performance (given this is called for every element of every transform). Or is
there another way to declare this for critical parts of the code. (In
particular, isinstance can be slow. It's not common convention to disable
asserts in Python.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 369264)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 42h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
