[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=369603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369603
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 04:07
Start Date: 10/Jan/20 04:07
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364991139
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -808,7 +810,7 @@ class AppliedPTransform(object):
def __init__(self,
parent,
- transform, # type: ptransform.PTransform
+ transform, # type: Optional[ptransform.PTransform]
Review comment:
On the second issue, I should point that mypy knows that `proto.spec` is not
`None` when we call `PTransform. from_runner_api(proto.spec, context)` (because
`proto.spec` is always non-None), and we could _almost_ use that knowledge to
solve this problem with `@overload`s of `PTransform.from_runner_api()`, like
this:
```python
@overload
@classmethod
def from_runner_api(cls,
proto, # type: None
context # type: PipelineContext
):
# type: (...) -> None
pass
@overload
@classmethod
def from_runner_api(cls,
proto, # type: beam_runner_api_pb2.FunctionSpec
context # type: PipelineContext
):
# type: (...) -> PTransform
pass
@classmethod
def from_runner_api(cls, proto, context):
if proto is None or not proto.urn:
return None
```
Unfortunately, typing can't track whether the value of `proto.urn` is an
empty string, which means that the above overload strategy doesn't actually
work. Is there any chance that this could be changed to `if proto is None or
proto.urn is None`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 369603)
Time Spent: 46.5h (was: 46h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 46.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
