[
https://issues.apache.org/jira/browse/BEAM-9027?focusedWorklogId=369870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369870
]
ASF GitHub Bot logged work on BEAM-9027:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 14:35
Start Date: 10/Jan/20 14:35
Worklog Time Spent: 10m
Work Description: robinyqiu commented on issue #10538: [BEAM-9027]
Backport BigQuerySqlDialect fixes
URL: https://github.com/apache/beam/pull/10538#issuecomment-573059101
Thanks for working on this! LGTM.
Should we create a JIRA to track the fixes we pulled in from Calcite? This
way we can delete the changes here after we move to a new vendored Calcite
version. It would be great if we leave some TODOs in comments as well.
Also, I believe this PR also pulled in fixes from
https://github.com/apache/calcite/commit/fd92642d8a0b08ed0b1b4ccefd0de58d6239dd03#diff-9af1cfe9e5a5bdae5b7e22d28c70089a.
Would you like to mention this as well in the PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 369870)
Time Spent: 3h 40m (was: 3.5h)
> [SQL] ZetaSQL unparsing should produce valid result
> ---------------------------------------------------
>
> Key: BEAM-9027
> URL: https://issues.apache.org/jira/browse/BEAM-9027
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> * ZetaSQL does not recognize keyword INTERVAL
> * Calcite cannot unparse RexNode back to bytes literal
> * Calcite cannot unparse some floating point literals correctly
> * Calcite cannot unparse some string literals correctly
> * Calcite cannot unparse types correctly for CAST function
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
