[
https://issues.apache.org/jira/browse/BEAM-8337?focusedWorklogId=369975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369975
]
ASF GitHub Bot logged work on BEAM-8337:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 18:25
Start Date: 10/Jan/20 18:25
Worklog Time Spent: 10m
Work Description: ibzib commented on issue #10549: [BEAM-8337] Hard-code
Flink versions.
URL: https://github.com/apache/beam/pull/10549#issuecomment-573151082
We could've fixed the bash instead. I prefer this way because the publish
script no longer has to either make a clone or be run from within an up to
date clone, instead it can be run from anywhere.
On Fri, Jan 10, 2020 at 10:20 AM Maximilian Michels <
[email protected]> wrote:
> *@mxm* approved this pull request.
>
> Seems fair to change this if the bash version approach is too fragile.
> ------------------------------
>
> In release/src/main/scripts/publish_docker_images.sh
> <https://github.com/apache/beam/pull/10549#discussion_r365365136>:
>
> > FLINK_IMAGE_NAME=apachebeam/flink${ver}_job_server
> +
> + # Pull verified RC from dockerhub.
> + docker pull "${FLINK_IMAGE_NAME}:${RELEASE}_${RC_VERSION}"
> +
> + # Tag with ${RELEASE} and push to dockerhub.
> + docker tag "${FLINK_IMAGE_NAME}:${RELEASE}_${RC_VERSION}"
"${FLINK_IMAGE_NAME}:${RELEASE}"
>
> Looks like the indention is off here (3 instead of 2 spaces).
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/10549?email_source=notifications&email_token=AD2L6NW5MTEVYQ7UWB5WFBDQ5C37BA5CNFSM4KFBDZ2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRMGJQQ#pullrequestreview-341337282>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AD2L6NS4R45EHTHKNBYV2ZLQ5C37BANCNFSM4KFBDZ2A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 369975)
Time Spent: 6h 20m (was: 6h 10m)
> Add Flink job server container images to release process
> --------------------------------------------------------
>
> Key: BEAM-8337
> URL: https://issues.apache.org/jira/browse/BEAM-8337
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Could be added to the release process similar to how we now publish SDK
> worker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
