[
https://issues.apache.org/jira/browse/BEAM-8625?focusedWorklogId=370107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-370107
]
ASF GitHub Bot logged work on BEAM-8625:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 22:43
Start Date: 10/Jan/20 22:43
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #10553: [BEAM-8625]
Implement servlet for exposing sdk harness statuses in Da…
URL: https://github.com/apache/beam/pull/10553#discussion_r365447360
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowRunnerHarness.java
##########
@@ -120,24 +127,35 @@ public static void main(String[] unusedArgs) throws
Exception {
loggingServer =
serverFactory.create(ImmutableList.of(beamFnLoggingService),
loggingApiService);
+ // Grpc server for obtaining SDK harness runtime status information.
+ if (statusApiService != null && beamWorkerStatusGrpcService != null) {
Review comment:
This check seems to be redundant here.
If we expect `statusApiService` to be null, then we should check it before
`beamWorkerStatusGrpcService` creation.
Also, I expect `BeamWorkerStatusGrpcService.create` to throw exception if
the creation fails so it will never be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 370107)
Time Spent: 0.5h (was: 20m)
> Implement servlet in Dataflow runner for sdk status query endpoint
> ------------------------------------------------------------------
>
> Key: BEAM-8625
> URL: https://issues.apache.org/jira/browse/BEAM-8625
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
