[
https://issues.apache.org/jira/browse/BEAM-8331?focusedWorklogId=370991&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-370991
]
ASF GitHub Bot logged work on BEAM-8331:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/20 18:52
Start Date: 13/Jan/20 18:52
Worklog Time Spent: 10m
Work Description: vectorijk commented on pull request #10559: [BEAM-8331]
rewrite jdbc url in vendored calcite
URL: https://github.com/apache/beam/pull/10559#discussion_r365968832
##########
File path: vendor/calcite-1_20_0/build.gradle
##########
@@ -21,10 +21,10 @@ plugins { id 'org.apache.beam.vendor-java' }
description = "Apache Beam :: Vendored Dependencies :: Calcite 1.20.0"
group = "org.apache.beam"
-version = "0.1"
+version = "0.2"
def calcite_version = "1.20.0"
Review comment:
sure, I will bump the calcite_version to `1.21.0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 370991)
Time Spent: 50m (was: 40m)
> Vendored calcite breaks if another calcite is on the class path
> ---------------------------------------------------------------
>
> Key: BEAM-8331
> URL: https://issues.apache.org/jira/browse/BEAM-8331
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Affects Versions: 2.15.0, 2.16.0
> Reporter: Andrew Pilloud
> Assignee: Kai Jiang
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If the beam vendored calcite and a non-vendored calcite are both on the
> classpath, neither version works. This is because the non-JDBC calcite path
> uses JDBC as a easy way to perform reflection. (This affects the non-JDBC
> version of calcite.) We need to rewrite the calcite JDBC urls as part of our
> vendoring (for example 'jdbc:calcite:' to 'jdbc:beam-vendor-calcite:').
> Example of where this happens:
> [https://github.com/apache/calcite/blob/0cce229903a845a7b8ed36cf86d6078fd82d73d3/core/src/main/java/org/apache/calcite/tools/Frameworks.java#L175]
>
> {code:java}
> java.lang.RuntimeException: java.lang.RuntimeException: Property
> 'org.apache.beam.sdk.extensions.sql.impl.planner.BeamRelDataTypeSystem' not
> valid for plugin type org.apache.calcite.rel.type.RelDataTypeSystem
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:160)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:115)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLPlannerImpl.<init>(ZetaSQLPlannerImpl.java:86)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.<init>(ZetaSQLQueryPlanner.java:55){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
