[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=371026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371026
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/20 19:33
Start Date: 13/Jan/20 19:33
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #10368: [BEAM-8335]
Modify PipelineInstrument to add TestStream for unbounded PCollections
URL: https://github.com/apache/beam/pull/10368#discussion_r365988022
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -375,12 +377,15 @@ def _read_cache(self, pipeline, pcoll):
# Can only read from cache when the cache with expected key exists.
if self._cache_manager.exists('full', key):
if key not in self._cached_pcoll_read:
+ if pcoll.is_bounded:
+ read_transform = cache.ReadCache(self._cache_manager, key)
+ else:
+ read_transform = streaming_cache.StreamingCacheReceiver()
+
# Mutates the pipeline with cache read transform attached
# to root of the pipeline.
- pcoll_from_cache = (
- pipeline
- | '{}{}'.format(READ_CACHE, key) >> cache.ReadCache(
- self._cache_manager, key))
+ pcoll_from_cache = (pipeline
Review comment:
Have these source generated pcolls been added to the `self.cacheables` so
that they can get a `self.cache_key()`?
Or do you want to add a different execution path for these pcolls so that
they can get unique cache keys?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 371026)
Time Spent: 53h (was: 52h 50m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 53h
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
