[
https://issues.apache.org/jira/browse/BEAM-8933?focusedWorklogId=371049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371049
]
ASF GitHub Bot logged work on BEAM-8933:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/20 19:50
Start Date: 13/Jan/20 19:50
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10369:
[BEAM-8933] BigQueryIO Arrow for read
URL: https://github.com/apache/beam/pull/10369#discussion_r365975586
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -552,18 +553,26 @@ public static Read read() {
.setBigQueryServices(new BigQueryServicesImpl())
.setParseFn(parseFn)
.setMethod(Method.DEFAULT)
+ .setFormat(DataFormat.AVRO)
.build();
}
@VisibleForTesting
- static class TableRowParser implements SerializableFunction<SchemaAndRecord,
TableRow> {
+ public static class TableRowParser implements
SerializableFunction<SchemaAndRecord, TableRow> {
Review comment:
I'm not clear on why this needs to be `public` now. It looks like its still
only used in tests that are in the same package. Can't it stay package-private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 371049)
> BigQuery IO should support read/write in Arrow format
> -----------------------------------------------------
>
> Key: BEAM-8933
> URL: https://issues.apache.org/jira/browse/BEAM-8933
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> As of right now BigQuery uses Avro format for reading and writing.
> We should add a config to BigQueryIO to specify which format to use: Arrow or
> Avro (with Avro as default).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
