[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=371259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371259
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/20 01:08
Start Date: 14/Jan/20 01:08
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r366109412
##########
File path: sdks/python/apache_beam/portability/__init__.py
##########
@@ -17,3 +17,18 @@
"""For internal use only; no backwards-compatibility guarantees."""
from __future__ import absolute_import
+
+from typing import TYPE_CHECKING
+from typing import NamedTuple
+
+if TYPE_CHECKING:
+ from apache_beam.portability.api import metrics_pb2
+
+
+PropertiesFromEnumValue = NamedTuple(
Review comment:
I believe it has to be below `apache_beam.portability` because when the urn
generation runs we are in the middle of the beam build process, and IIRC it's
not reliable to import `apache_beam` at this point. So the solve was to treat
the `portability.api` package as the root package to import and inspect only
the generated pb2 modules. So it would need to be something like
`apache_beam.portability.utils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 371259)
Time Spent: 49h 50m (was: 49h 40m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 49h 50m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
