[
https://issues.apache.org/jira/browse/BEAM-9116?focusedWorklogId=372868&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-372868
]
ASF GitHub Bot logged work on BEAM-9116:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/20 08:48
Start Date: 16/Jan/20 08:48
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10580: [BEAM-9116] Limit
the number of past invocations stored in JobService
URL: https://github.com/apache/beam/pull/10580#discussion_r367293773
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/JobServerDriver.java
##########
@@ -97,6 +98,9 @@ protected InMemoryJobService createJobService() throws
IOException {
handler = ExplicitBooleanOptionHandler.class)
private boolean cleanArtifactsPerJob = true;
+ @Option(name = "--history-size", usage = "The maximum number of completed
invocations to keep.")
Review comment:
This name is user-facing and does not have to reflect the internal design
decisions. The usage description could be improved:
>"The maximum number of completed jobs to keep."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 372868)
Time Spent: 2h (was: 1h 50m)
> Limit the number of past invocations stored in the job service
> --------------------------------------------------------------
>
> Key: BEAM-9116
> URL: https://issues.apache.org/jira/browse/BEAM-9116
> Project: Beam
> Issue Type: Bug
> Components: jobserver
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The {{InMemoryJobService}} stores an unbounded number of past job
> invocations. When this job server is long-running this can cause memory
> issues, as seen with our test setup for running Python tests.
> We should limit the number of past job invocations via a flag in the job
> server with a sensible default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
