[
https://issues.apache.org/jira/browse/BEAM-8564?focusedWorklogId=373189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373189
]
ASF GitHub Bot logged work on BEAM-8564:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/20 17:55
Start Date: 16/Jan/20 17:55
Worklog Time Spent: 10m
Work Description: amoght commented on pull request #10254: [BEAM-8564]
Add LZO compression and decompression support
URL: https://github.com/apache/beam/pull/10254#discussion_r367564910
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/io/CompressedSourceTest.java
##########
@@ -738,7 +1069,133 @@ public void testGzipProgress() throws IOException {
assertThat(readerOrig, instanceOf(CompressedReader.class));
CompressedReader<Byte> reader = (CompressedReader<Byte>) readerOrig;
// before starting
- assertEquals(0.0, reader.getFractionConsumed(), 1e-6);
+ assertEquals(0.0, reader.getFractionConsumed(), DELTA);
+ assertEquals(0, reader.getSplitPointsConsumed());
+ assertEquals(1, reader.getSplitPointsRemaining());
+
+ // confirm has three records
+ for (int i = 0; i < numRecords; ++i) {
+ if (i == 0) {
+ assertTrue(reader.start());
+ } else {
+ assertTrue(reader.advance());
+ }
+ assertEquals(0, reader.getSplitPointsConsumed());
+ assertEquals(1, reader.getSplitPointsRemaining());
+ }
+ assertFalse(reader.advance());
+
+ // after reading empty source
Review comment:
line 325: public void testReadConcatenatedLzo() throws IOException:
Is this for LZOP codec? Since unlike LZOP, LZO Codec supports file
concatenation. Also we have testReadMultiStreamLzo and
testFalseReadConcatenatedLzop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 373189)
Time Spent: 7h 20m (was: 7h 10m)
> Add LZO compression and decompression support
> ---------------------------------------------
>
> Key: BEAM-8564
> URL: https://issues.apache.org/jira/browse/BEAM-8564
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Amogh Tiwari
> Assignee: Amogh Tiwari
> Priority: Minor
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> LZO is a lossless data compression algorithm which is focused on compression
> and decompression speeds.
> This will enable Apache Beam sdk to compress/decompress files using LZO
> compression algorithm.
> This will include the following functionalities:
> # compress() : for compressing files into an LZO archive
> # decompress() : for decompressing files archived using LZO compression
> Appropriate Input and Output stream will also be added to enable working with
> LZO files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
