[ 
https://issues.apache.org/jira/browse/BEAM-5086?focusedWorklogId=374569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-374569
 ]

ASF GitHub Bot logged work on BEAM-5086:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jan/20 14:21
            Start Date: 20/Jan/20 14:21
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on issue #10561: [BEAM-5086] Update 
kudu-client to version 1.11.1
URL: https://github.com/apache/beam/pull/10561#issuecomment-576295502
 
 
   I agree with you in the sense that this is a question of judgment, but I 
don’t think we should assume any extreme position in particular for 
dependencies that ‘are working’. Of course it is clear that the goal is that 
Beam users have a experience with no issues and we should fix linkage issues 
that impede the use of such libraries on Beam for example if we cannot read 
Data from Kudu because some of those linkage errors.
   
   Taking the responsibility of fixing every linkage issue that is not related 
to Beam is a considerable amount of work for in many cases not much in return. 
Linkage errors on bad shaded libraries provided by other projects happen 
commonly on unused execution paths, otherwise they would be  detected as errors 
in the dependency and fixed by the provider project.
   
   The important deal is to have a clear frontier of which are client provider 
problems that we may be inclined to fix so they don’t break the usage of the 
library for our users, but even in that case it makes more sense to provide the 
solution in the dependent project first. To save Beam of the extra maintenance.
   
   We should not be adding the extra work of dealing with this to Beam. I am 
afraid that this would be an endless task because I have seen the devil of 
doing this for Hadoop and friends or basically that nobody shades some deps 
well (yes I am looking at you netty) and we can be ‘fixing’ them for some IO 
just to discover that the new added (and unused paths) conflict with the 
version that a runner use. Also we may end up with leaking dependencies that we 
pinned in our side to fix linkage errors, but that the upstream project may fix 
in the future and it will be also hard to discover / track the extra 
dependencies removal in our side.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 374569)
    Time Spent: 1.5h  (was: 1h 20m)

> Beam Dependency Update Request: org.apache.kudu
> -----------------------------------------------
>
>                 Key: BEAM-5086
>                 URL: https://issues.apache.org/jira/browse/BEAM-5086
>             Project: Beam
>          Issue Type: Bug
>          Components: dependencies, io-java-kudu
>            Reporter: Beam JIRA Bot
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> 2018-08-06 12:13:43.606551
>         Please review and upgrade the org.apache.kudu to the latest version 
> None 
>  
>         cc: 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to