[
https://issues.apache.org/jira/browse/BEAM-9093?focusedWorklogId=375240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375240
]
ASF GitHub Bot logged work on BEAM-9093:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/20 21:59
Start Date: 21/Jan/20 21:59
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #10613: [BEAM-9093] Log
invalid overwrites in pipeline options
URL: https://github.com/apache/beam/pull/10613#discussion_r369264919
##########
File path: sdks/python/apache_beam/options/pipeline_options_test.py
##########
@@ -264,6 +264,18 @@ def test_override_options(self):
self.assertEqual(options.get_all_options()['num_workers'], 5)
self.assertTrue(options.get_all_options()['mock_flag'])
+ def test_override_init_options(self):
+ base_flags = ['--num_workers', '5']
+ options = PipelineOptions(base_flags, mock_flag=True)
+ self.assertEqual(options.get_all_options()['num_workers'], 5)
+ self.assertEqual(options.get_all_options()['mock_flag'], True)
+
+ def test_invalid_override_init_options(self):
+ base_flags = ['--num_workers', '5']
+ options = PipelineOptions(base_flags, mock_invalid_flag=True)
+ self.assertEqual(options.get_all_options()['num_workers'], 5)
+ self.assertEqual(options.get_all_options()['mock_flag'], False)
Review comment:
It would be great if we could also capture the logging in addition to only
checking `mock_flag` is untouched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 375240)
Time Spent: 40m (was: 0.5h)
> Pipeline options which with different underlying store variable does not get
> over written
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-9093
> URL: https://issues.apache.org/jira/browse/BEAM-9093
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ankur Goenka
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Example:
> PipelineOptions(flags=[],**\{'no_use_public_ips': True,})
> Expectation: use_public_ips should be set False.
> Actual: the value is not used as its not passed through argparser
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
