[
https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=375354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375354
]
ASF GitHub Bot logged work on BEAM-7961:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/20 01:22
Start Date: 22/Jan/20 01:22
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #10051: [BEAM-7961] Add
tests for all runner native transforms for XLang
URL: https://github.com/apache/beam/pull/10051#discussion_r369329159
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1684,22 +1688,21 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', "$pythonDir/scripts/run_expansion_services.sh stop
--group_id ${project.name}"
}
setupTask.finalizedBy cleanupTask
+ config.startJobServer.finalizedBy config.cleanupJobServer
// Task for running testcases in Java SDK
def beamJavaTestPipelineOptions = [
-
"--runner=org.apache.beam.runners.portability.testing.TestPortableRunner",
- "--jobServerDriver=${config.jobServerDriver}",
+ "--runner=PortableRunner",
Review comment:
The change enabled remote execution of portable pipelines.
`TestPortableRunner` provides `--jobServerDriver` just for easier testing
(otherwise there needs to be a separate jobserver process to run integration
tests). Validate xlang test suite already implemented the setup/shutdown script
managing external processes so I modified the code to adopt the original
`PortableRunner`. I didn't check but OOM shouldn't happen with the new tests
here even with in-process job server drivers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 375354)
Time Spent: 16h (was: 15h 50m)
> Add tests for all runner native transforms and some widely used composite
> transforms to cross-language validates runner test suite
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-7961
> URL: https://issues.apache.org/jira/browse/BEAM-7961
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 16h
> Remaining Estimate: 0h
>
> Add tests for all runner native transforms and some widely used composite
> transforms to cross-language validates runner test suite
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
