[
https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375778
]
ASF GitHub Bot logged work on BEAM-9063:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/20 18:04
Start Date: 22/Jan/20 18:04
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10612: [NOT READY TO
MERGE][BEAM-9063] migrate docker images to apache
URL: https://github.com/apache/beam/pull/10612#discussion_r369716555
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ReleaseInfo.java
##########
@@ -59,10 +59,22 @@ public String getSdkVersion() {
return getProperties().get("sdk_version");
}
+ /** Provides docker image default root (apache). */
+ public String getDefaultDockerRepoRoot() {
+ return getProperties().get("docker_image_default_repo_root");
+ }
+
+ /** Provides docker image default repo prefix (beam-). */
+ public String getDefaultDockerRepoPrefix() {
+ return getProperties().get("docker_image_default_repo_prefix");
+ }
+
/////////////////////////////////////////////////////////////////////////
private static final Logger LOG = LoggerFactory.getLogger(ReleaseInfo.class);
private static final String DEFAULT_NAME = "Apache Beam SDK for Java";
private static final String DEFAULT_VERSION = "Unknown";
+ private static final String DEFAULT_DOCKER_IMAGE_ROOT = "apache";
+ private static final String DEFAULT_DOCKER_IMAGE_PREFIX = "beam-";
Review comment:
```suggestion
private static final String DEFAULT_DOCKER_IMAGE_PREFIX = "beam_";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 375778)
Time Spent: 4h (was: 3h 50m)
> Migrate docker images to apache namespace.
> ------------------------------------------
>
> Key: BEAM-9063
> URL: https://issues.apache.org/jira/browse/BEAM-9063
> Project: Beam
> Issue Type: Task
> Components: beam-community
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> https://hub.docker.com/u/apache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
