[
https://issues.apache.org/jira/browse/BEAM-3419?focusedWorklogId=375975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375975
]
ASF GitHub Bot logged work on BEAM-3419:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/20 00:13
Start Date: 23/Jan/20 00:13
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10648: [BEAM-3419]
Support iterable on Dataflow runner when using the unified worker.
URL: https://github.com/apache/beam/pull/10648#discussion_r369874409
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -320,24 +320,32 @@ def visit_transform(self, transform_node):
for ix, side_input in enumerate(transform_node.side_inputs):
access_pattern = side_input._side_input_data().access_pattern
if access_pattern == common_urns.side_inputs.ITERABLE.urn:
- # Add a map to ('', value) as Dataflow currently only handles
- # keyed side inputs.
- pipeline = side_input.pvalue.pipeline
- new_side_input = _DataflowIterableSideInput(side_input)
- new_side_input.pvalue = beam.pvalue.PCollection(
- pipeline,
- element_type=typehints.KV[
- bytes, side_input.pvalue.element_type],
- is_bounded=side_input.pvalue.is_bounded)
- parent = transform_node.parent or pipeline._root_transform()
- map_to_void_key = beam.pipeline.AppliedPTransform(
- pipeline,
- beam.Map(lambda x: (b'', x)),
- transform_node.full_label + '/MapToVoidKey%s' % ix,
- (side_input.pvalue,))
- new_side_input.pvalue.producer = map_to_void_key
- map_to_void_key.add_output(new_side_input.pvalue)
- parent.add_part(map_to_void_key)
+ if use_unified_worker:
+ # Patch up the access pattern to appease Dataflow when using
Review comment:
Filed BEAM-9173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 375975)
Time Spent: 5h (was: 4h 50m)
> Enable iterable side input for beam runners.
> --------------------------------------------
>
> Key: BEAM-3419
> URL: https://issues.apache.org/jira/browse/BEAM-3419
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
